Skip to content

Conversation

Sumeet213
Copy link
Contributor

Description of the change

Added threading support to FileServiceClient to make discovery_api thread-local.

Motivation

Fixes a threading issue where multiple threads could simultaneously access self._discovery_api, leading to bugs. Making discovery_api thread-local gives each thread its own instance.

Resolves: #327

Type of change

Bug fix

Checklist

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:python sdk Issue/PR related to Python SDK labels Oct 3, 2024
@MarkDaoust MarkDaoust merged commit db8221a into google-gemini:main Oct 24, 2024
10 checks passed
@github-actions github-actions bot removed the status:awaiting review PR awaiting review from a maintainer label Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:python sdk Issue/PR related to Python SDK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants